Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cdk.json to devenv list #908

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Adds cdk.json to devenv list #908

merged 2 commits into from
Jan 12, 2024

Conversation

dburriss
Copy link
Contributor

@dburriss dburriss commented Dec 27, 2023

This addresses #883

If cdk.json exists in the folder, dev will install the AWS CDK CLI.

image

@coveralls
Copy link

coveralls commented Dec 27, 2023

Pull Request Test Coverage Report for Build 7498681701

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 97.396%

Totals Coverage Status
Change from base Build 7422369046: 0.004%
Covered Lines: 1429
Relevant Lines: 1459

💛 - Coveralls

@mxcl mxcl force-pushed the main branch 3 times, most recently from 7947ae5 to 533350e Compare January 5, 2024 13:22
@mxcl
Copy link
Member

mxcl commented Jan 9, 2024

Thanks for the contribution!

What sort of test should I write for this? I see the tests for this but don't really understand "supplemental fixture" vs "fixed fixture".

Not sure I remember either. Just add a fixture to ./fixtures that you can then add to one of the arrays in the tests for dev and then get coverage up. If the lines are covered we're good.

How would I test this manually? Can I install pkgx from my branch, test it, then flip bach to stable easily?

$ deno task install

Will install your checkout to /usr/local/bin/pkgx, the shellcode will use that.

@dburriss dburriss marked this pull request as ready for review January 12, 2024 08:20
@dburriss
Copy link
Contributor Author

@mxcl 1 issue I did run into was that it was still picking up the 1.1.1 version when I ran dev. I just brew uninstalled pkgx and it then used my developer version.

✅ Tests are in and passing.
✅ The manual test worked (see description).

@mxcl
Copy link
Member

mxcl commented Jan 12, 2024

1 issue I did run into was that it was still picking up the 1.1.1 version when I ran dev. I just brew uninstalled pkgx and it then used my developer version.

Oh ok, I imagine your brew PATH is ahead of /usr/local/bin so yeah, that would happen. I can probs make the deno task install savvy to that so it warns you. Thanks for the heads up

@mxcl mxcl merged commit ed796ae into pkgxdev:main Jan 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants